This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
More pre-integration work #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,45 +63,50 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
|
|
|||
| emission.switchBoardModule.presentNavigationViewController = ^(UIViewController * _Nonnull fromViewController, | |||
There was a problem hiding this comment.
perhaps this should take an animated option, I could see times when you'd want to handle something non-animated
There was a problem hiding this comment.
That sounds like a nice change for @sarahscott to do post v1 to dip her toes into RN native modules.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this work PR merged, you should be able to easily run a release build on your device and start QAin artist VCs.