Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle analyzer dashboard to track js assets over time #4684

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

zephraph
Copy link
Contributor

This is a trial of the bundle-analyzer dashboard service. It's a free service that provides a dashboard to track bundle asset changes over time.

It may and/or may not be useful. We'll remove it again if it proves not to be useful.

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #4684 into master will decrease coverage by <.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4684     +/-   ##
========================================
- Coverage    79.3%   79.2%   -0.1%     
========================================
  Files        1268    1268             
  Lines       35050   35291    +241     
  Branches     1992    2029     +37     
========================================
+ Hits        27799   27976    +177     
- Misses       6226    6263     +37     
- Partials     1025    1052     +27

@zephraph
Copy link
Contributor Author

I haven't been able to get the size checks to pick up, but that might require the config to be in master. I remove the bundlesizes check to reduce redundancy between the service checks.

What do you think @alloy? Want to try it out for a bit?

@alloy
Copy link
Contributor

alloy commented Oct 16, 2019

Sure, let’s do it 👍

@alloy alloy merged commit dfddbb1 into master Oct 16, 2019
@alloy alloy deleted the bundle-analyzer-dashboard branch October 16, 2019 16:16
@artsy-peril artsy-peril bot mentioned this pull request Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants