Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the newly created resolvers, and fixes the internal schema resolving for exchange #1291

Merged
merged 4 commits into from
Sep 21, 2018

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 20, 2018

OK, so this one really fixes the issues we were seeing. What happened is:

Now the internal schema (and its test fixtures) are always in sync.

Copy link
Contributor

@ashkan18 ashkan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge on green

}

export const transformsForExchange = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

}),
new RenameRootFields((_operation, name) => `ecommerce_${name}`),
])
const exchangeSchema = transformSchema(schema, transformsForExchange)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more copy/paste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants