Add traver through url #29
Conversation
|
Great! However it would be even better to apply these to all editable views. Another approach is to extend the default |
…onal operators. Extend ViewEditor Edit method. Underscore redundant variables.
wuzz.go
Outdated
| @@ -149,7 +133,12 @@ func (e *ViewEditor) Edit(v *gocui.View, key gocui.Key, ch rune, mod gocui.Modif | |||
| e.backTabEscape = true | |||
| return | |||
| } | |||
|
|
|||
| if key == gocui.KeyHome { | |||
| _ = e.GoToHome(v) | |||
There was a problem hiding this comment.
_ = is not necessary.
Another thing: isn't return required after these statements? Without returning the original editor function will be called as well. Alternatively it can be turned into a switch-case statement like this:
switch key {
case gocui.KeyHome:
e.GoToHome(v)
default:
e.origEditor.Edit(..)There was a problem hiding this comment.
What exactly is backTabEscape?
There was a problem hiding this comment.
@Eraden there is no such thing "backtab" or "shift+tab" in terminal, if you press shift+tab it generates the sequence \033]Z. The purpose of this function is to catch these character sequences. backTabEscape is a boolean state flag, which is true if the previous key was the first part of the "backtab" sequence.
.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| wuzz | |||
There was a problem hiding this comment.
This doesn't seem appropriate as part of this commit to me.
There was a problem hiding this comment.
Agree, @Eraden could you open another PR with this change?
wuzz.go
Outdated
| @@ -164,7 +153,7 @@ func (e *SearchEditor) Edit(v *gocui.View, key gocui.Key, ch rune, mod gocui.Mod | |||
| func (a *App) Layout(g *gocui.Gui) error { | |||
| maxX, maxY := g.Size() | |||
| if maxX < MIN_WIDTH || maxY < MIN_HEIGHT { | |||
| if v, err := g.SetView("error", 0, 0, maxX-1, maxY-1); err != nil { | |||
| if v, err := g.SetView("error", 0, 0, maxX - 1, maxY - 1); err != nil { | |||
There was a problem hiding this comment.
Why are these formatting changes in the same commit as the above functional changes? This makes for some pretty messy history, IMO.
There was a problem hiding this comment.
True, I will reverse it and squash commit.
| @@ -832,7 +818,7 @@ func setViewTextAndCursor(v *gocui.View, s string) { | |||
| v.SetCursor(len(s), 0) | |||
| } | |||
|
|
|||
| func quit(g *gocui.Gui, v *gocui.View) error { | |||
| func quit(_ *gocui.Gui, _ *gocui.View) error { | |||
There was a problem hiding this comment.
I personally don't see the value in eliding the argument names here, but that's a style call that @asciimoo should probably make the final decision on.
There was a problem hiding this comment.
I suppose this is the proper go way, but go fmt does not correct it.
This mod is OK to me in another PR.
|
Thank you the PR and your work, but another Implementation of this functionality has been merged: #39 |
Related to #27