Disable multiline on url and method views #39
Conversation
There was a problem hiding this comment.
This looks good, and works well on initial examination. I particularly like the up/down scrolling in the "method" view - that's really handy.
Is there any reason not to include the search field as well? I don't see why that should be multiline, as the inability to see more than one line makes it very confusing when you inadvertently go to a new line. \n can be used to make the regex match multiple lines, and doesn't have the same problem.
If that's an unintentional omission, I would suggest adding a commit that applies your singlelineEditor to that field.
Thanks for the PR! It's definitely something that was needed.
| @@ -19,7 +19,7 @@ $ "$GOPATH/bin/wuzz" --help | |||
| ### Commands | |||
|
|
|||
| Keybinding | Description | |||
| ----------------------------------------|------------------------------------------------------------ | |||
| ----------------------------------------|--------------------------------------- | |||
There was a problem hiding this comment.
Perhaps this is too nitpicky, but this change doesn't seem to fit with this commit or PR.
There was a problem hiding this comment.
Yeah, that was just a fix to keep the README at 79cols. I don't think it need a commit on its own, but i can split it if needed
| e.wuzzEditor.Edit(v, key, ch, mod) | ||
| } | ||
|
|
||
| // |
There was a problem hiding this comment.
This looks like it was left in accidentally.
There was a problem hiding this comment.
Just a separator with line 111 // Editor funcs
That was not unintentional, because I had a bug with it, but its OK now. |
wuzz.go
Outdated
| @@ -166,6 +207,7 @@ func (a *App) Layout(g *gocui.Gui) error { | |||
| setViewDefaults(v) | |||
| v.Editable = true | |||
| v.Title = "URL params (F3)" | |||
| v.Editor = &singlelineEditor{defaultEditor} | |||
There was a problem hiding this comment.
It is allowed to break lines in the GET parameter view too, so I'd suggest to use just the default editor here
There was a problem hiding this comment.
Yeah but we can't use multilines requests now because Enter will launch request and will not break lines.
There was a problem hiding this comment.
Enter only works in the URL view as far as I know.
There was a problem hiding this comment.
Indeed i thought it was the url view, my bad
|
Thanks the fixes. I found another regression: it does not handle shift+tab. Still not fully clear why, if you have any idea, let me know |
|
Found it : editor passed by value and not reference for |
cyberj
force-pushed
the
master
branch
2 times, most recently
from
8f580a6
to
bd6ca98
Compare
|
Rebased and squashed (on master sorry) |
|
Awesome! Thanks. |
url,method&searchviews by creating asinglelineEditorurlandsearchview jumps at beginning and end of linemethodview change the method in the same order of themethod-listpopup