New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Merge into Danger Swift #17

Closed
orta opened this Issue Dec 16, 2018 · 1 comment

Comments

2 participants
@orta
Copy link
Contributor

orta commented Dec 16, 2018

This is likely to be one of the main reasons people use Danger Swift, I think it makes sense to probably just include in in core to save on some of the expense of Danger plugins ( e.g. #14 ). While I think this can be fixed, I'm not sure if it can be done in an elegant way (danger swift has to be compiled twice if you're not using a package.swift for example )

This related to the discussion in danger/swift#139

@ashfurrow

This comment has been minimized.

Copy link
Owner

ashfurrow commented Dec 16, 2018

Yup, I followed up in that conversation but the rationale makes total sense to me 👍 Let me know what I can do to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment