Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Fix for issue #72 #85

Merged
merged 3 commits into from
Dec 21, 2013
Merged

Fix for issue #72 #85

merged 3 commits into from
Dec 21, 2013

Conversation

streetlogics
Copy link
Contributor

Call me crazy, but if this is return false, this function will always return false, since emptyBucket defaults to true, and therefore the call to set emptyBucket to false will never execute?

Call me crazy, but if this is return false, this function will always return false, since emptyBucket defaults to true, and therefore the call to set emptyBucket to false will never execute?
…ignore all files, just a nice trick to have the default folder structure setup for scripts and such
@askmike
Copy link
Owner

askmike commented Dec 21, 2013

I will merge this in but will revert 5f75324 right away as that won't fix the problem:

The return false breaks out of the everyloop
Gekko expects that if you request trades since time X you always get newer ones back, the check makes sure that is the case.
The reason why that is failing with cex.io is because of the hardcoded tid, which is from before the first bucketTime
you should not get that error anymore when you already filled a database (as long as the newest in there is newer than the first bucketTime)

The real problem is described here.

askmike added a commit that referenced this pull request Dec 21, 2013
@askmike askmike merged commit ef7323d into askmike:master Dec 21, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants