Skip to content

Override TryComputeLength(...) in web host HttpContent implementations #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2018
Merged

Override TryComputeLength(...) in web host HttpContent implementations #212

merged 3 commits into from
Nov 21, 2018

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Nov 21, 2018

@dougbu dougbu requested a review from Tratcher November 21, 2018 06:13
Tratcher
Tratcher requested changes Nov 21, 2018
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 your triggering sync IO from a property getter. Trying to fix Length is the wrong approach, fix the HttpContent implementations to not guess Content-Length.

@Tratcher Tratcher assigned dougbu and unassigned Tratcher Nov 21, 2018
@Tratcher
Copy link
Member

Also, please stop assigning your PRs to the reviewers. The reviewers feature works just fine.

@dougbu
Copy link
Contributor Author

dougbu commented Nov 21, 2018

please stop assigning your PRs to the reviewers

Some notice one and some notice the other. I'll keep your request in mind for you in particular.

@dougbu dougbu removed their assignment Nov 21, 2018
@dougbu dougbu changed the title Add Length override in SeekableBufferredRequestStream Override TryComputeLength(...) in web host HttpContent implementations Nov 21, 2018
@dougbu
Copy link
Contributor Author

dougbu commented Nov 21, 2018

🆙📅

@dougbu dougbu merged commit 523f3aa into master Nov 21, 2018
@dougbu dougbu deleted the dougbu/chunked.formatters.197 branch November 21, 2018 18:37
@dougbu
Copy link
Contributor Author

dougbu commented Nov 21, 2018

523f3aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dougbu @Tratcher