Skip to content

Address a few more nits #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

Address a few more nits #378

merged 1 commit into from
Jan 20, 2023

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Jan 20, 2023

  • avoid repeated NuGet.exe downloads
    • remove extra bits in modern file versions before parsing
  • suppress warnings about targeting netcoreapp2.1

@dougbu
Address a few more nits
24fe70a 
- avoid repeated NuGet.exe downloads
  - remove extra bits in modern file versions before parsing
- suppress warnings about targeting `netcoreapp2.1`
wtgodbe
wtgodbe reviewed Jan 20, 2023
View reviewed changes
@dougbu dougbu merged commit 8515e0b into aspnet:main Jan 20, 2023
@dougbu dougbu deleted the dougbu/version.fixup.and.more branch January 20, 2023 18:45
@dougbu dougbu added this to the 3.3.0 (5.3.0) milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck

@TanayParikh TanayParikh Awaiting requested review from TanayParikh

@Nick-Stanton Nick-Stanton Awaiting requested review from Nick-Stanton

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0 (5.3.0)-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @wtgodbe