Add ClientManager usage to management sample
#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SignalR client output sample: ``` User 'User' with connection id 'CKZhiNk__nyv3Vrz8SnK_Q1448c44c1' connected. User: gets message from service: 'aaa' ``` MessagePublisher output sample: ``` *********Usage********* send user <User Id> <Message> send users <User Id List (Seperated by ',')> <Message> send group <Group Name> <Message> send groups <Group List (Seperated by ',')> <Message> usergroup add <User Id> <Group Name> usergroup remove <User Id> <Group Name> broadcast <Message> close <Connection ID> <Reason> checkexist connection <Connection ID> checkexist user <User ID> checkexist group <Group Name> *********************** > checkexist connection CKZhiNk__nyv3Vrz8SnK_Q1448c44c1 connection 'CKZhiNk__nyv3Vrz8SnK_Q1448c44c1' exists. > checkexist connection CKZhiNk__nyv3Vrz8SnK_Q1448c44c2 connection 'CKZhiNk__nyv3Vrz8SnK_Q1448c44c2' does not exist. > checkexist user User user 'User' exists. > send user User abc send message 'abc' to 'User' ```
Y-Sindo
force-pushed
the
zityang/management
branch
from
4c4b7de to
cc6b7e2
Compare
Y-Sindo
changed the title
ClientManager usage to management sample
wanlwanl
reviewed
Sep 16, 2021
| if (ex == null) | ||
| { | ||
| Console.WriteLine("If you expect non-null exception, you need to turn on 'EnableDetailedErrors' option during client negotiation."); | ||
| } |
There was a problem hiding this comment.
how about simply turn on it?
There was a problem hiding this comment.
EnableDetailedErrors is not recommended by SignalR, so I don't turn on it by default.
There was a problem hiding this comment.
I think the If you expect non-null exception, you need to turn on is wierd here, how about making EnableDetailedErrors an option when you start negotiation server?
wanlwanl
reviewed
Sep 16, 2021
| }); | ||
| ``` | ||
| `EnableDetailedErrors` defaults to false because these exception messages can contain sensitive information. | ||
| ## Full Sample |
There was a problem hiding this comment.
how about make it in format
EnableDetailedErrorsdefaults to false because these exception messages can contain sensitive information.
so that reader can easily get the note
wanlwanl
reviewed
Sep 16, 2021
| else if (args.Length == 3 && args[0] == "checkexist") | ||
| { | ||
| var exist = await publisher.CheckExist(args[1].ToLowerInvariant(), args[2]); | ||
| Console.WriteLine(exist ? $"{args[1]} '{args[2]}' exists." : $"{args[1]} '{args[2]}' does not exist."); |
wanlwanl
reviewed
Sep 16, 2021
| else if (args.Length == 2 && args[0] == "close") | ||
| { | ||
| await publisher.CloseConnection(args[1], null); | ||
| Console.WriteLine($"Close connection '{args[1]}'."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignalR client output sample:
MessagePublisher output sample: