-
Notifications
You must be signed in to change notification settings - Fork 25.1k
CommandLine config provider overhaul #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommandLine config provider overhaul #4307
Conversation
Updates Updates
@guardrex, |
The build doesn't like it too much that I add a readme.md. They (or MS) must have that locked down a little bit, so I'm going to remove that file. The contents are simply:
|
@guardrex can you add yourself as an author? |
@Rick-Anderson Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvements!
Thanks @HaoK! |
@Rick-Anderson If you don't want the 1.x tab there, we'd still need to work out how to show the reader the use of Do you want me to take a stab at getting the 1.x part (tab) out while keeping the content? ... imo it would be good to keep all of the content here but re-organize it to drop the 1.x tab. I can have it done by tomorrow morning. |
@guardrex keep the 1.x tab. For new content updates, we'll drop the 1.x content and just update docs for 2.x (and point to https://github.com/aspnet/Docs/blob/master/aspnetcore/common/_static/9-25-17.pdf) |
@guardrex can I merge or do you need more work? We can leave the 1.x tabs. |
@Rick-Anderson Thanks. I'm cool. Go ahead. I was only concerned about the 1.x tab situation. |
Internal review URL
Fixes #2409
Fixes #1382
🎸 Jam'in! 🎷
Review site topic
This turned out to be a considerable overhaul of the CommandLine config provider section:
cc/ @danroth27