Skip to content

Conversation

@ajcvickers
Copy link
Contributor

Issue #6522

Service was already scoped, so the change is minimal.

Issue #6522

Service was already scoped, so the change is minimal.
@AndriySvyryd
Copy link
Member

MigrationsModelDiffer.Sort should be split into two methods so that it doesn't need to be completely reimplemented when adding an operation

@ajcvickers
Copy link
Contributor Author

@AndriySvyryd Filed #6529

@bricelam
Copy link
Contributor

Should MigrationsModelDiffer move out of .Internal?

@ajcvickers
Copy link
Contributor Author

@bricelam Possibly, if we are recommending that it be extended for this scenario. Currently the service is public, but our implementation is internal, which is normal for services that we expect people to replace. But if we expect the service to be replaced by extending the existing implementation, then it probably should be public.

@ajcvickers
Copy link
Contributor Author

It's probably worth saying that the point of this PR is to allow the PostgreSQL provider to do what it is currently doing in a way that is friendly in multiple provider scenarios. While we can choose to do more to support doing this, for example, without using internal code, it is valid for a provider to use internal code as long as it is understood that the provider may be broken when there is an EF update. So I think we should get this change in as a minimum step, and then choose to do more or not as appropriate.

@rowanmiller
Copy link
Contributor

Agreed with not needing to move the implementation out of internal at this stage

@bricelam
Copy link
Contributor

Given our design meeting discussion on this, I think we can close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants