Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Consider moving TagHelperOutput.Generate*() functionality to RazorPage.Write in Mvc. #318

@sornaks

Description

@sornaks

Quoting @dougbu 's comment:

for future consideration (not this PR) but related to the TagHelperContent / DefaultTagHelperContent split introduced here: suggest we split TagHelperOutput along similar lines and get the Generate*() methods and perhaps ContentSet out of tag helper authors' faces.

This split could go further and move the Generate*() methods completely out of this class (or class hierarchy). if _isTagNameNullOrWhitespace were exposed as a property (like ContentSet), these methods would not require any private information. could move generation many places but I suggest the RazorPage.WriteLiteral[To]([TextWriter,] TagHelperExecutionContext) methods I proposed elsewhere. in any case, this would pull apart the mix of responsibilities TagHelperOutput has today.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions