-
Notifications
You must be signed in to change notification settings - Fork 220
Introducing buffering in TagHelperOutput.PreContent, Content, PostContent #312
Conversation
Hi @sornaks, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
TTYL, MSOTBOT; |
d0a071c
to
3ff2c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw this in the previous if statement as an ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"that is appended to the content" -> "to be appended" (use consistent wording)
⌚ for #312 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teensy nit: in future don't remove the trailing initializer commas. you're more likely to get nits to add them.
⌚ |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we skip adding the value
if it's null? would be consistent with Append(TagHelperContent)
Updated.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!string.IsNullOrEmpty()
(almost-always weird to just null
-check a string
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why would you want to ignore string.Empty
?
|
…end is called with null.
|
Checked in. Thanks guys! bd9d57d |
#296. Looking for comments around naming.