res_audiosocket: add message type 0x11 for slin16 audio messages #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending audiosocket messages of type AST_AUDIOSOCKET_KIND_AUDIO_SLIN16 (0x11) creates Asterisk frames in the slin16 format, enabling the transmission of audio at a higher sample rate. For audiosocket messages sent by Asterisk, the message kind is determined by the format of the originating Asterisk frame. UpgradeNote: A new audiosocket message type (0x11) has been added for slin16 audio. External applications using audiosocket may need to be updated to support this message type if the audiosocket channel is created with slin16 as the codec.
|
cherry-pick-to: 23 |
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Workflow PRCheck completed successfully |
|
It might be more flexible to include the sample rate in kHz in the message payload (1 byte should be enough?), then you could send any signed-linear data regardless of rate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending audiosocket messages of type AST_AUDIOSOCKET_KIND_AUDIO_SLIN16 (0x11) creates Asterisk frames in the slin16 format, enabling the transmission of audio at a higher sample rate. For audiosocket messages sent by Asterisk, the message kind is determined by the format of the originating Asterisk frame.
UpgradeNote: A new audiosocket message type (0x11) has been added for slin16 audio. External applications using audiosocket may need to be updated to support this message type if the audiosocket channel is created with slin16 as the codec.