Allow selection of the axis for angle measurement to the North #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pyregion` computes the image rotation angle using as the angle between North and X-axis instead of typically adopted convention of using Y-axis for image orientation computations. This produces regions that are rotated compared to the regions produced by DS9 when image axes are non-orthogonal (at least for HST images). The proposed here fix consists in introducing an additional parameter `rot_wrt_axis` (can take values 1 or 2) to let users select what axis should be used for computing image rotations (-> rotations of regions). For example, by setting `rot_wrt_axis`=2 `pyregion` now will use `rot2` (angle between Y-axis and North) instead of `rot1` (in ``wcs_converter.py``) in computing region rotations.
leejjoon
added a commit
that referenced
this pull request
May 27, 2014
Allow selection of the axis for angle measurement to the North
sargas
added a commit
to sargas/pyregion
that referenced
this pull request
Nov 16, 2014
Needs test cases I'm not too sure how well the approximation in estimate_angle works for non-orthagonal axes, but it is identical to what was used before in pull request astropy#34 Also add a test for loading some imagecoords with WCS instead of Header
sargas
added a commit
to sargas/pyregion
that referenced
this pull request
Mar 30, 2016
Needs test cases I'm not too sure how well the approximation in estimate_angle works for non-orthagonal axes, but it is identical to what was used before in pull request astropy#34 Also add a test for loading some imagecoords with WCS instead of Header
This was referenced Aug 2, 2016
sargas
added a commit
to sargas/pyregion
that referenced
this pull request
Aug 8, 2016
Needs test cases I'm not too sure how well the approximation in estimate_angle works for non-orthagonal axes, but it is identical to what was used before in pull request astropy#34 Also add a test for loading some imagecoords with WCS instead of Header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyregioncomputes the image rotation angle using as the angle between North and X-axis instead of typically adopted convention of using Y-axis for image orientation computations. This produces regions that are rotated compared to the regions produced by DS9 when image axes are non-orthogonal (at least for HST images). The proposed here fix consists in introducing an additional parameterrot_wrt_axis(can take values 1 or 2) to let users select what axis should be used for computing image rotations (-> rotations of regions). For example, by settingrot_wrt_axis=2,pyregionnow will userot2(angle between Y-axis and North) instead ofrot1(inwcs_converter.py) in computing region rotations.This replaces a part of the PR #29.