Skip to content

docs: add features and output section in readme #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

aayushmau5
Copy link
Member

Description

  • Added Features and Output section in README

@aayushmau5
Copy link
Member Author

aayushmau5 commented May 27, 2022

@derberg Are we missing something in the README? Let me know, I'll add them as well.

@@ -90,6 +95,33 @@ const output = diff(firstDocument, secondDocument, {
});
```

## Output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushmau5 Not sure, maybe we can present the different possible values in a tabular form?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinitshahdeo What do you mean by tabular form 🤔 ?

@derberg
Copy link
Member

derberg commented Jun 7, 2022

lgtm, just not sure what @vinitshahdeo meant about tabular view

@aayushmau5 aayushmau5 requested a review from magicmatatjahu June 7, 2022 14:05
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aayushmau5 aayushmau5 marked this pull request as draft June 14, 2022 04:52
@aayushmau5 aayushmau5 marked this pull request as ready for review June 14, 2022 04:53
@aayushmau5 aayushmau5 merged commit 7b02f49 into asyncapi:master Jun 14, 2022
@aayushmau5 aayushmau5 deleted the readme-update-features branch June 14, 2022 05:13
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants