-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add 3.0.0 validation support #208
Conversation
/au |
Yeah, long-living branches are a pain. In the future we should probably leverage feature flags or similar. I vote for merging this PR already. Other improvements and fixes can be done in minor and patch versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can already merge this.
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
SonarCloud Quality Gate failed. 4 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
ready to merge, sonar complains about CI building which can be later ignored anyway, not runtime related |
🎉 🥳 |
🎉 This PR is included in version 6.0.0-next-major-spec.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
When this is merged, from version 6 and onwards, all pre-release spec versions will be released as a regular feature request, before the spec itself is released.
The pre-release version will be released as if it was not a pre-release, for example for AsyncAPI 3.0, it will be released as normal:
However, while the it's still a pre-release, the underlying schemas CAN contain breaking changes from version to version, up until the spec is released. This means that one AsyncAPI document using v3 in the pre-release stage might be valid in
6.0.0
, but invalid in the6.1.0
. This ONLY applies to pre-release schemas, and NOT regular ones that is set in stone.If you want to make sure you don't use a schema not released yet, you have to whitelist which versions you allow in your tool.
This PR is created upfront to reflect on a daily basis what things are included in the release.
Also, the reason to create this PR a long time before the release is to enable automation (bot keeps upstream branches always up to date with master, see this action) that we have in place to regularly update the release branch with whatever is changed in the master branch. So nobody has to do it manually.