Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: links styleguide added #1328

Closed
wants to merge 6 commits into from
Closed

docs: links styleguide added #1328

wants to merge 6 commits into from

Conversation

octonawish-akcodes
Copy link
Contributor

@octonawish-akcodes octonawish-akcodes commented Feb 11, 2023

Links style guide added.

Related issue(s)
#1255

@netlify
Copy link

netlify bot commented Feb 11, 2023

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1a2dc44
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6553aacc40a87b000806eb88

pages/docs/community/styleguide/links.md Outdated Show resolved Hide resolved
pages/docs/community/styleguide/links.md Outdated Show resolved Hide resolved
pages/docs/community/styleguide/links.md Outdated Show resolved Hide resolved
pages/docs/community/styleguide/links.md Outdated Show resolved Hide resolved
@@ -0,0 +1,35 @@
# Link Style Guide 📃
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Link Style Guide 📃
# Introduction

This section should introduce this doc.

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and address the current feedback and make sure you take time to rewrite content based also on the great feedback left by @starlightknown :)

Looking forward to your next draft!

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Feb 22, 2023
@quetzalliwrites quetzalliwrites linked an issue Feb 22, 2023 that may be closed by this pull request
18 tasks
@quetzalliwrites quetzalliwrites linked an issue Feb 22, 2023 that may be closed by this pull request
@octonawish-akcodes
Copy link
Contributor Author

@alequetzalli @starlightknown I have made suitable changes based on the feedback.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1328--asyncapi-website.netlify.app/

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 23, 2023
@octonawish-akcodes octonawish-akcodes closed this by deleting the head repository Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: new style guide - Links
3 participants