Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: og meta tags and Url rendering issue #3032

Closed
wants to merge 3 commits into from

Conversation

sambhavgupta0705
Copy link
Member

This pr fixes the URL rendering issue of meta tags and url
#2639

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c365b8b
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66673016b2db0500083be883
😎 Deploy Preview https://deploy-preview-3032--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sambhavgupta0705 sambhavgupta0705 changed the title fix : OG meta tags and Url rendering issue fix: OG meta tags and Url rendering issue Jun 10, 2024
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jun 10, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3032--asyncapi-website.netlify.app/

@sambhavgupta0705 sambhavgupta0705 changed the title fix: OG meta tags and Url rendering issue fix: og meta tags and Url rendering issue Jun 10, 2024
@sambhavgupta0705
Copy link
Member Author

@aeworxet
I researched on this issue and it is a hydration error of the i18n project which is for all the projects
When we remove the null component from the hydration render the tags are partially visible and for the frontpage we can pass the headcomponent only

image

If we remove the hydration render then it is throwing an error
Had a word with other maintainers also and it seems that we need to change a lot of configuration ot we can remove i18n feature
cc: @akshatnema @anshgoyalevil

@sambhavgupta0705
Copy link
Member Author

Apart from this the url rendering issue has been resolved and the meta tags one is blocked by hydration error we seems a little advanced issue as it is the error of i18n library only and the configuration we have installed for it

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Jun 10, 2024
@asyncapi-bot asyncapi-bot removed the bounty AsyncAPI Bounty program related label label Jul 23, 2024
@sambhavgupta0705 sambhavgupta0705 added bounty AsyncAPI Bounty program related label and removed bounty AsyncAPI Bounty program related label labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants