feat: add tests for Index and build pages script #3044
Conversation
…into jestTests
vishvamsinh28
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
asyncapi-bot
requested review from
sambhavgupta0705,
BhaswatiRoy,
J0SAL,
TRohit20 and
VaishnaviNandakumar
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3044--asyncapi-website.netlify.app/ |
anshgoyalevil
added
the
gsoc
…bsite into caseStudiesTest
| fs.mkdirSync(TEST_DIR, { recursive: true }); | ||
| fs.mkdirSync(SRC_DIR, { recursive: true }); | ||
| fs.mkdirSync(TARGET_DIR, { recursive: true }); |
There was a problem hiding this comment.
fs module works in CI and locally in tests, then why have you mocked all those function calls in previous test PRs?
There was a problem hiding this comment.
These tests seems to be perfect. Why haven't you used the actual fs module in previous PRs? Any specific reason?
|
I felt like mocking was a better approach for them, but with this script, I thought using the actual fs module would be better. I also did it to experiment with the actual fs module, and it worked well. 😅 But as you commented on other PRs i will update tests for them as well and use fs module without mocking it |
|
/rtm |
This PR adds test for index.js and build-pages.js scripts