Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blog landing page having problem with showing 2 authors names #3051

Merged
merged 17 commits into from
Jul 26, 2024

Conversation

TenzDelek
Copy link
Contributor

Description
made changes in the reduce method

image

Related issue(s)
Fixes #3050

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit acd53bf
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66a382387972b900086222c2
😎 Deploy Preview https://deploy-preview-3051--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jun 20, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3051--asyncapi-website.netlify.app/

@TenzDelek
Copy link
Contributor Author

@derberg i have run npm run lint:fix and it is affecting different files (total of 258). should i just commit or only the blogpost.tsx is enough.
image

@derberg
Copy link
Member

derberg commented Jun 24, 2024

@anshgoyalevil can you help please 🙏🏼

@anshgoyalevil
Copy link
Member

anshgoyalevil commented Jun 25, 2024

@TenzDelek Are you on Windows OS? If that's the case, you can set the VSCode's Line break to CRLF. Please don't commit the changes related to linebreak settings (not even for BlogPost.tsx file). It might fail the lint check, and can also cause problems to Linux/OSX users

@TenzDelek
Copy link
Contributor Author

@anshgoyalevil yup, mine is windows !!. i have made the changes . hopefully it doesnt fail the test

@sambhavgupta0705
Copy link
Member

@anshgoyalevil can you please into this

@sambhavgupta0705
Copy link
Member

/update

@@ -128,4 +132,4 @@ export default forwardRef(function BlogPostItem(
</article>
</li>
);
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TenzDelek just add a new line here and it will solve the issue

@TenzDelek
Copy link
Contributor Author

@sambhavgupta0705 check it once if it is correct 👍

@sambhavgupta0705
Copy link
Member

/update

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@TenzDelek
Copy link
Contributor Author

@derberg can you verify the changes once ..

@derberg
Copy link
Member

derberg commented Jul 26, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 63d64bf into asyncapi:master Jul 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blog landing page has problem with showing 2 authors names
5 participants