-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: blog landing page having problem with showing 2 authors names #3051
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3051--asyncapi-website.netlify.app/ |
@derberg i have run |
@anshgoyalevil can you help please 🙏🏼 |
@TenzDelek Are you on Windows OS? If that's the case, you can set the VSCode's Line break to CRLF. Please don't commit the changes related to linebreak settings (not even for BlogPost.tsx file). It might fail the lint check, and can also cause problems to Linux/OSX users |
@anshgoyalevil yup, mine is windows !!. i have made the changes . hopefully it doesnt fail the test |
@anshgoyalevil can you please into this |
/update |
@@ -128,4 +132,4 @@ export default forwardRef(function BlogPostItem( | |||
</article> | |||
</li> | |||
); | |||
}); | |||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TenzDelek just add a new line here and it will solve the issue
@sambhavgupta0705 check it once if it is correct 👍 |
/update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
@derberg can you verify the changes once .. |
/rtm |
Description
made changes in the reduce method
Related issue(s)
Fixes #3050