Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add supported by section on landing page #558

Merged
merged 12 commits into from
Jan 25, 2022
Merged

feat: add supported by section on landing page #558

merged 12 commits into from
Jan 25, 2022

Conversation

Samridhi-98
Copy link
Contributor

Description

  • Added supportus.js
  • Modified index.js
  • Added img/supportus

Related issue(s)

Fixes #557

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for asyncapi-website ready!

🔨 Explore the source changes: be9c3f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/61eff0b1764869000752b95b

😎 Browse the preview: https://deploy-preview-558--asyncapi-website.netlify.app

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Samridhi-98
Copy link
Contributor Author

@derberg please review my PR.

@derberg derberg changed the title feat: supported by section on landing page feat: add supported by section on landing page Jan 20, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot. I only left some comments to texts, and also that some logs are old I think

Also please if possible use svg, and if not available, convert png to webp

components/SupportUs.js Outdated Show resolved Hide resolved
components/SupportUs.js Outdated Show resolved Hide resolved
components/SupportUs.js Outdated Show resolved Hide resolved
components/SupportUs.js Outdated Show resolved Hide resolved
components/SupportUs.js Outdated Show resolved Hide resolved
components/SupportUs.js Outdated Show resolved Hide resolved
components/SupportUs.js Outdated Show resolved Hide resolved
components/SupportUs.js Outdated Show resolved Hide resolved
pages/index.js Outdated
<Container className="text-center py-6" wide>
<h3 className="text-primary-800 text-3xl font-bold md:text-4xl mb-4">Supported by</h3>
<p className="mt-3 max-w-2xl mx-auto text-xl leading-7 text-gray-500 sm:mt-4">
These companies support us by letting us use their products for free.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could add a sentence that if someone wants to supports us, should write to info@asyncapi.io

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, so they know what action item to take!!

@derberg
Copy link
Member

derberg commented Jan 20, 2022

@fmvilas @mcturco you folks might wanna have a look. I'm not 100% sure the current location I proposed is good, maybe it should be closer to sponsors?

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but Want to Support us is not on the next line but next to first, we should fix that.

image

Also Want to Support us is good sentence here? Should it be question? I am currently treating this as an order 😅

@magicmatatjahu
Copy link
Member

@Samridhi-98 Maybe sentence like:

These companies support us by letting us use their products for free. Want to become a supporter? Support us!

but I think that @alequetzalli should look at this :)

@mcturco
Copy link
Member

mcturco commented Jan 20, 2022

I think it looks good but maybe it would be better if the section was placed just above the blog posts section? I just think it makes more sense just below the testimonials. And probably would be better if it wasn't all the way at the bottom of the site.

The only other thing I see is that the Digital Ocean logo looks like its a little squished horizontally. It looks like the left and right padding might be causing that, but only for the Digital Ocean logo.

@fmvilas
Copy link
Member

fmvilas commented Jan 20, 2022

Yeah, would also like to add that it's not looking great on mobile and tablets. Please, check that too 🙏

@quetzalliwrites
Copy link
Member

quetzalliwrites commented Jan 20, 2022

@Samridhi-98 Maybe sentence like:

These companies support us by letting us use their products for free. Want to become a supporter? Support us!

but I think that @alequetzalli should look at this :)

Hey @magicmatatjahu, hoping my reply helps! 😀👍🏽

Okay, so I think it sounds strange how often we keep using the word support for this one. I would potentially only use the word twice at most. Additionally, @derberg suggested we give them an email to reach out to us and take action. Maybe we can re-write this to something such as:

The following companies support us by letting us use their products for free. Interested in supporting us too? Email info@asyncapi.io for more info.

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fmvilas
Copy link
Member

fmvilas commented Jan 22, 2022

This is how it looks at 662px wide (some tablets):

Captura de pantalla 2022-01-22 a las 13 30 22

Maybe we can use two columns when the width is not of mobile but also not desktop. What do you think?

@Samridhi-98
Copy link
Contributor Author

This is how it looks at 662px wide (some tablets):

Captura de pantalla 2022-01-22 a las 13 30 22

Maybe we can use two columns when the width is not of mobile but also not desktop. What do you think?

@fmvilas I have made some changes and now it looks like this

image

I think there is no need to have two columns.

@fmvilas
Copy link
Member

fmvilas commented Jan 22, 2022

@Samridhi-98 Awesome. Looks great now. Thanks! 🙏

PS: The build is failing, apparently related to node-fetch (nothing related to your code). Maybe you want to look into that?

@Samridhi-98
Copy link
Contributor Author

@Samridhi-98 Awesome. Looks great now. Thanks! 🙏

PS: The build is failing, apparently related to node-fetch (nothing related to your code). Maybe you want to look into that?

I am unable to figure out how to fix it. 😢😢

@fmvilas
Copy link
Member

fmvilas commented Jan 22, 2022

No problem, happy to help you. Pinging you on Slack.

pages/index.js Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Jan 25, 2022

after checking I think all feedback was taken into account, and it is ready to merge.

/rtm

@asyncapi-bot asyncapi-bot merged commit 6509d89 into asyncapi:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add on landing page info about companies that support us with their products
7 participants