-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add supported by section on landing page #558
feat: add supported by section on landing page #558
Conversation
✔️ Deploy Preview for asyncapi-website ready! 🔨 Explore the source changes: be9c3f8 🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/61eff0b1764869000752b95b 😎 Browse the preview: https://deploy-preview-558--asyncapi-website.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@derberg please review my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it a lot. I only left some comments to texts, and also that some logs are old I think
Also please if possible use svg
, and if not available, convert png
to webp
pages/index.js
Outdated
<Container className="text-center py-6" wide> | ||
<h3 className="text-primary-800 text-3xl font-bold md:text-4xl mb-4">Supported by</h3> | ||
<p className="mt-3 max-w-2xl mx-auto text-xl leading-7 text-gray-500 sm:mt-4"> | ||
These companies support us by letting us use their products for free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could add a sentence that if someone wants to supports us, should write to info@asyncapi.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, so they know what action item to take!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samridhi-98 Maybe sentence like:
but I think that @alequetzalli should look at this :) |
I think it looks good but maybe it would be better if the section was placed just above the blog posts section? I just think it makes more sense just below the testimonials. And probably would be better if it wasn't all the way at the bottom of the site. The only other thing I see is that the Digital Ocean logo looks like its a little squished horizontally. It looks like the left and right padding might be causing that, but only for the Digital Ocean logo. |
Yeah, would also like to add that it's not looking great on mobile and tablets. Please, check that too 🙏 |
Hey @magicmatatjahu, hoping my reply helps! 😀👍🏽 Okay, so I think it sounds strange how often we keep using the word support for this one. I would potentially only use the word twice at most. Additionally, @derberg suggested we give them an email to reach out to us and take action. Maybe we can re-write this to something such as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@fmvilas I have made some changes and now it looks like this I think there is no need to have two columns. |
@Samridhi-98 Awesome. Looks great now. Thanks! 🙏 PS: The build is failing, apparently related to |
I am unable to figure out how to fix it. 😢😢 |
No problem, happy to help you. Pinging you on Slack. |
after checking I think all feedback was taken into account, and it is ready to merge. /rtm |
Description
supportus.js
index.js
img/supportus
Related issue(s)
Fixes #557