-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add new consumer concept doc #991
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hello @alequetzalli & @derberg, I will love your feedbacks. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-991--asyncapi-website.netlify.app/ |
pages/docs/concepts/consumer.md
Outdated
## What is a Consumer? | ||
In an Event Driven Architecture (EDA), a consumer is a component of an application or messaging system that listens for a particular event from a broker and takes the necessary action in response. | ||
|
||
## Why do we need Consumers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Why do we need Consumers? | |
## What is the purpose of Consumers? |
This is the outline all Concept Docs will have: What is the purpose of _____?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will correct that asap!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't hate but i changed my mind :D haha!
Let's stick with your original one, I went ahead and fixed it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Left some comments
thought: since we have producer document already in master
maybe, maybe it is good it interlink them? So at the end of your document you can add a note like: "yo, subscribers can actually also be producers. Go to this blabla to learn what producer is". and similar note could be added to the producer
doc. Thoughts?
pages/docs/concepts/consumer.md
Outdated
--- | ||
|
||
## What is a Consumer? | ||
In an Event Driven Architecture (EDA), a consumer is a component of an application or messaging system that listens for a particular event from a broker and takes the necessary action in response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an Event Driven Architecture (EDA), a consumer is a component of an application or messaging system that listens for a particular event from a broker and takes the necessary action in response. | |
In an Event Driven Architecture (EDA), a consumer is an application that listens for a particular event from a broker and reacts to it. |
application
I think it is good to be consistent with producer document that was just released
takes the necessary action in response
I would avoid response
as it is known term in request/response pattern, and might be suggest consumer sends a response
pages/docs/concepts/consumer.md
Outdated
In an Event Driven Architecture (EDA), a consumer is a component of an application or messaging system that listens for a particular event from a broker and takes the necessary action in response. | ||
|
||
## What is the purpose of Consumers? | ||
Unlike traditional RestAPIs, EDA creates a setting where there is never a wait for requests or responses to an event. In this pattern, a consumer is unaware of the producer or other consumers; all they know is that when a broker sends them an event they are subscribed to, they receive it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike traditional RestAPIs, EDA creates a setting where there is never a wait for requests or responses to an event. In this pattern, a consumer is unaware of the producer or other consumers; all they know is that when a broker sends them an event they are subscribed to, they receive it. | |
Unlike traditional REST APIs, in EDA, consumers of the event are not expected to respond immediately on the same connection. In this architecture, a consumer is unaware of the producer or other consumers; all they know is that when a broker sends them an event, it is because they subscribed to it. |
how about this? just to clarify about communication that it is not on sync, because sometimes people do request/response in EDA, but it is still async. Like in DM on Slack, you send question, you do not know who will answer, but you definitely expect that in a thread at some point of time someone will send a response. Makes sense
you can freely adjust the paragraph, my suggestions are just to "visualize" what I mean
pages/docs/concepts/consumer.md
Outdated
f | ||
end | ||
``` | ||
The diagram above depicts an example of the flow of events from a producer to a broker and then to the consumers. In this instance, the producer publishes two events, A & B and sends to the broker. Then each consumer receives events from what it is subscribed to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diagram above depicts an example of the flow of events from a producer to a broker and then to the consumers. In this instance, the producer publishes two events, A & B and sends to the broker. Then each consumer receives events from what it is subscribed to. | |
The diagram above depicts an example of the flow of events from a producer to a broker and then to the consumers. In this instance, the producer publishes two events, A & B, and sends them to the broker. Then each consumer receives events that they are subscribed to. |
Great idea! |
I will make all the requested changes. Thanks @derberg |
Dear @alequetzalli & @derberg, I just updated the content to be in sync with the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! I just noticed one formatting issue
pages/docs/concepts/consumer.md
Outdated
The above diagram depicts a sample flow of events from producer to broker and consumer. In this instance, the producer publishes two events, A & B, and sends them to the broker. Then each consumer subscribes to receive those events. | ||
|
||
<Remember> | ||
`Subscribers` can also be [`producers`](https://www.asyncapi.com/docs/concepts/producer). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh haha noooo. ✌🏽😂
In this scenario, I believe Anisat's original idea to use our React Remember
component is a good idea because it's a helpful visual reminder that stands out.
The solution (to me) is to instead use appropriate HTML tags within our React Remember
component, and then teach Anisat that we can't use MD syntax in these components. 😄🙌🏽
@Annysah heyo, just pinging you as looks like just one tiny change is needed and we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🛳 🚢 🛳 🚢 🛳 🚢 🛳 🚢 🛳 🚢 🛳 🚢 🛳
@all-contributors please add @Annysah for docs |
I've put up a pull request to add @Annysah! 🎉 |
Description
Related issue(s)
Fixes #975