-
Notifications
You must be signed in to change notification settings - Fork 371
Docker changes and optimisations #148
base: master
Are you sure you want to change the base?
Conversation
@kawaii node-8.16 is now the latest node 8 version. |
@rmm5t thank you for informing me of this, I simply based my commit from your earlier PR without checking Docker Hub for updated information. Perhaps it would be best for us to test the application under a more modern Node.js version such as 11 or 12? |
Odd numbers are unstable versions. Version 12 was just released this week. Node 10 is probably the most appropriate for now. |
I've made some more pushes with some general quality of life improvements to the |
Bump! Anyone with merge powers able to check this over? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have merge powers, but maybe a code review and another set of eyes on this will help.
Screams into cyberspace, but no one hears. |
This really should be merged. Thanks, using your fork in a project now |
Some small yet quite important changes. All tested and documented below:
mkdir /opt/camo
layer of theDockerfile
sinceWORKDIR
makes the directory if it doesn't already exist..dockerignore
file and changes 3ADD
layers into a single one with the same effect.