Skip to content

Conversation

kbrose
Copy link

@kbrose kbrose commented Oct 13, 2017

This is an attempt to fix #20.

I do not have access to a Mac, so I cannot check verify that this change does't re-introduce #4.

@lgeiger
Copy link
Collaborator

lgeiger commented Oct 13, 2017

@kbrose Thanks a lot for your PR! 👍

Unfortunately this re-introduces #4 since atom.getLoadSettings().env doesn't correctly get the PATH on mac. As soon as I find time I'll test this again and see if it's a bug in Atom core or if we can find a better solution that works on linux too.

@lgeiger lgeiger closed this Oct 13, 2017
@kbrose
Copy link
Author

kbrose commented Oct 13, 2017

It doesn't? Do you have a pointer to a discussion about that?

@kbrose
Copy link
Author

kbrose commented Oct 13, 2017

What about atom.updateProcessEnv and process.env?

@lgeiger
Copy link
Collaborator

lgeiger commented Oct 13, 2017

What about atom.updateProcessEnv and process.env?

Thanks for the suggestions, unfortunately both don't help either 😕
Looks like we're running into an Atom bug here.

Could you test if #29 works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ide-python starts rogue bash process

2 participants