Only use shell-env on mac #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works great! +1 from me! |
|
Wow that's great! Thanks for the super fast testing 👍 🎉 |
|
@kbrose Would you be interested in helping maintaining this package? I'd be happy to add you to the repo. |
|
Sure, I'd be happy to help out |
|
That's awesome! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason Atom only detects the correct env if started from the command line on Mac.
Strangely
process.env.PATHis correct when evaluating it in the dev tools. Unfortunately in this fileprocess.envhas the wrong value.atom.updateProcessEnv()doesn't help either. 😕This looks like a bug in Atom.
@kbrose Could you test if this fixes the CPU issues on Linux?