Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

partialMatchTimeout not used with a key combo that is both a prefix and bound to a command #129

Open
dimfeld opened this issue Apr 22, 2016 · 1 comment
Open

partialMatchTimeout not used with a key combo that is both a prefix and bound to a command #129

dimfeld opened this issue Apr 22, 2016 · 1 comment

Comments

@dimfeld
Copy link

dimfeld commented Apr 22, 2016 •
edited
Loading

Atom 1.7.2 on OSX 10.11.4

When a particular key combination is bound to a command and is also a prefix for other commands, the partialMatchTimeout doesn't appear to work properly.

Easiest steps to reproduce:

  1. Install git-plus package
  2. Look at the package settings and note the default keybindings have commands mapped to cmd-shift-a and cmd-shift-a s (and others)
  3. Open a file inside a git repo.
  4. Open key binding resolver
  5. Press cmd-shift-a
  6. Wait 1 second, and note that it's still waiting. (It appears to wait indefinitely)
  7. Press up arrow or anything else that cancels the wait. Only then does the git-plus:add command run.

To ensure this wasn't directly related to the git-plus package, I've also reproduced this in safe mode by binding a command such as core:copy to cmd-k, which has a number of 2-stroke bindings already set up.

See akonwi/git-plus#415 and akonwi/git-plus#419 for some related discussion. Some people there say this behavior appeared in the 1.5 branch, maybe between 1.5.3 and 1.5.4.
facebook-github-bot pushed a commit to facebookarchive/nuclide that referenced this issue Sep 8, 2016
@matthewwithanm
Add keyboard shortcuts for clearing the console
1d8ed7b 
Summary:
This adds a keyboard shortcut for clearing the console that matches Chrome's. A few things to note:

1. It's global (instead of being scoped to the input prompt).
2. Even though it's preferable, we don't use ⌘K because of its conflicts with partially matching pane moving shortcuts. Also, it's currently broken due to atom/atom-keymap#129.

Changelog: Add keyboard shortcut for clearing the console

Reviewed By: jgebhardt

Differential Revision: D3825846

fbshipit-source-id: e9970739ecf9fd78b6b2a87449503c20410aa2cc
@demin-dmitriy demin-dmitriy mentioned this issue Sep 10, 2016
Open
@banacorn
Copy link

+1. This is really annoying

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@banacorn @dimfeld