This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Console logging adapter #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
force-pushed
the
dg-console-logging
branch
from
414fc2c to
68336e1
Compare
daviwil
approved these changes
Mar 9, 2018
| this.detachAll(); | ||
| } | ||
|
|
||
| // Public: Attach this {LoggingConsoleAdapter} to a given {ConsoleService}. |
There was a problem hiding this comment.
Should the comment refer to ConsoleApi?
| this._consoles.add(console); | ||
| } | ||
|
|
||
| // Public: Remove all {V2IndieDelegate} registries attached to this adapter. |
There was a problem hiding this comment.
Looks like a stale comment from another adapter
This was referenced Mar 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wires up
workspace/logMessageto the Console in Atom-IDE-UI