Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Upgrade Relay to 1.6.0 #1428

Merged
merged 4 commits into from
May 3, 2018
Merged

Upgrade Relay to 1.6.0 #1428

merged 4 commits into from
May 3, 2018

Conversation

smashwilson
Copy link
Contributor

Upgrade Relay and associated dependencies to the latest version (1.6.0). Bring our GraphQL schema up to date and regenerate all generated query files.

Let's see if this breaks horribly 😅

@smashwilson
Copy link
Contributor Author

smashwilson commented May 1, 2018

The linter is consistently dying with this stacktrace:

  eslint:linter Linting code for /Users/smashwilson/src/atom/github/test/atom/pane-item.test.js (pass 1) +7ms
Cannot read property 'range' of null
TypeError: Cannot read property 'range' of null
    at SourceCode.getTokenBefore (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/token-store/index.js:303:18)
    at checkSpacingBefore (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/rules/template-curly-spacing.js:52:42)
    at TemplateElement (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/rules/template-curly-spacing.js:117:17)
    at listeners.(anonymous function).forEach.listener (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)

It looks like I'm hitting babel/babel-eslint#530, but none of the workarounds there seem to be working for me. I did a little digging to see if I could figure out what's going on within babel-eslint but no luck so far.

@smashwilson smashwilson mentioned this pull request May 2, 2018
@smashwilson
Copy link
Contributor Author

🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant