New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Relay to 1.6.0 #1428

Merged
merged 4 commits into from May 3, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented May 1, 2018

Upgrade Relay and associated dependencies to the latest version (1.6.0). Bring our GraphQL schema up to date and regenerate all generated query files.

Let's see if this breaks horribly 馃槄

smashwilson added some commits May 1, 2018

@smashwilson

This comment has been minimized.

Member

smashwilson commented May 1, 2018

The linter is consistently dying with this stacktrace:

  eslint:linter Linting code for /Users/smashwilson/src/atom/github/test/atom/pane-item.test.js (pass 1) +7ms
Cannot read property 'range' of null
TypeError: Cannot read property 'range' of null
    at SourceCode.getTokenBefore (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/token-store/index.js:303:18)
    at checkSpacingBefore (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/rules/template-curly-spacing.js:52:42)
    at TemplateElement (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/rules/template-curly-spacing.js:117:17)
    at listeners.(anonymous function).forEach.listener (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/Users/smashwilson/src/atom/github/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)

It looks like I'm hitting babel/babel-eslint#530, but none of the workarounds there seem to be working for me. I did a little digging to see if I could figure out what's going on within babel-eslint but no luck so far.

@smashwilson smashwilson referenced this pull request May 2, 2018

Merged

Remove babel-eslint #1430

@smashwilson

This comment has been minimized.

Member

smashwilson commented May 3, 2018

馃檶

@smashwilson smashwilson merged commit b790cf8 into master May 3, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/relay-up branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment