Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel-eslint #1430

Merged
merged 14 commits into from May 2, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

smashwilson commented May 2, 2018

While I was working on #1428, I encountered a snarl of a problem with babel-eslint and eslint. As far as I can tell, it involves incompatibilities between the latest releases of both, with a side helping of some fun inconsistencies between the way that npm and apm dedupe and flatten node_modules/ dependencies. Locking to older versions didn't even seem to help, I suspect because of some change in transitive dependencies.

Rather than trying to unravel this, I'm going to see how bad it is to get rid of our babel-eslint dependency.

@smashwilson smashwilson changed the title Remove decorators Remove babel-eslint May 2, 2018

smashwilson added some commits May 2, 2018

Remove the @shouldDelegate check
If we forget to delegate a method, then the test that actually tests it
will fail.

@smashwilson smashwilson merged commit 291d01d into master May 2, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/undecorated branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.