Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yubikiri to v2.0.0 #2010

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
2 participants
@BinaryMuse
Copy link
Member

commented Mar 7, 2019

Description of the Change

Heya, folks!

I've just updated Yubikiri to v2.0.0; most notably, this fixes a bug where values calculated from function resolvers might mistakenly be calculated more than once (e.g. this test would fail).

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

Fixes potential bugs as described above.

Possible Drawbacks

Yubikiri v2.0.0 was a rewrite from v1.0.0 (thus the major version bump), so there could be unforseen bugs that arise. That said, the test suite passes, and the updated package is working on a similar PR for electronjs.org.

Applicable Issues

N/A

Metrics

N/A

Tests

N/A

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

@codecov

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #2010 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2010   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files         189      189           
  Lines       11244    11244           
  Branches     1634     1634           
=======================================
  Hits        10410    10410           
  Misses        834      834

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f6679...20f3fe1. Read the comment docs.

@smashwilson
Copy link
Member

left a comment

👍 Sweet, thanks!

@smashwilson smashwilson merged commit 40e469e into master Mar 8, 2019

2 checks passed

codecov/patch Coverage not affected when comparing c0f6679...20f3fe1
Details
codecov/project 92.58% remains the same compared to c0f6679
Details

Sprint : 7 March 2019 - 3 April 2019 : v0.28.0 automation moved this from In progress to Merged Mar 8, 2019

@smashwilson smashwilson deleted the mkt/update-yubikiri-2-0-0 branch Mar 8, 2019

@smashwilson smashwilson referenced this pull request Apr 8, 2019

Closed

v0.28.0-0 QA Review #2051

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.