⬆️ Bump superstring from 2.4.2 to 2.4.3

[DeeDeeG]

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Update the indirect dependency superstring to 2.4.3 in package-lock.json. This was mostly a compatibility update for building against newer Node/Electron versions. (See: atom/superstring#80). Allows this package to be built against at least Electron 7.

(This PR is needed for the "Transpiling packages with custom transpiler configurations" step of Atom's script/build with Electron 7.)

More context:

I noticed @sadick254 has been updating several packages that would allow Atom to be built against Electron 7 (or even newer??). Thank you @sadick254!!!

This update in the github package is apparently the last compatibility update that would be needed before Atom can build against Electron 7. I have personally built Atom against Electron 7 with all the updated packages + this change. (More work would be needed to make Atom actually work as intended on Electron 7, but hey, at least it builds now!)

Screenshot or Gif

N/A

Applicable Issues

atom/superstring#80

[codecov]

Codecov Report

Merging #2583 (06af7d7) into master (12172d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2583   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files         237      237           
  Lines       13231    13231           
  Branches     1906     1906           
=======================================
  Hits        12365    12365           
  Misses        866      866           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12172d2...06af7d7. Read the comment docs.

[smashwilson]

Thanks!

[DeeDeeG]

CI passed 🎉 (except somehow Codecov is pretty sure this decreases JS test coverage, which I'm pretty sure it doesn't!) Oh actually Codecov is cool with this now.

[smashwilson]

Yeah, Codecov unifies coverage results from each platform build as they complete, so it almost always reports a coverage decrease, then an increase.

Also if Codecov wasn't happy with a package-lock.json change it would just be noise and I'd ignore it anyway 😂

[DeeDeeG]

Last comment I have for this thread... (beyond scope of this PR but there's no obvious place to mention it): Apparently this allows Atom to build against Electron 7 on macOS, but it's not quite there yet on Windows and Linux still.

CI run on my fork of Atom: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=882&view=results

(no response expected, just wanted to document this somewhere)