Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Don't use deprecated Buffer #2724

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Don't use deprecated Buffer #2724

merged 1 commit into from
Oct 26, 2021

Conversation

icecream17
Copy link
Contributor

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

According to https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/, Buffer(number) should be replaced by Buffer.alloc(number)

Screenshot or Gif

image

Applicable Issues

According to https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/, `Buffer(number)` should be replaced by `Buffer.alloc(number)`
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #2724 (1d6057d) into master (2053290) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2724   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         237      237           
  Lines       13213    13213           
  Branches     1900     1900           
=======================================
  Hits        12349    12349           
  Misses        864      864           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2053290...1d6057d. Read the comment docs.

Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smashwilson smashwilson merged commit be2baf3 into atom:master Oct 26, 2021
@icecream17 icecream17 deleted the patch-1 branch October 26, 2021 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants