This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix tokenising for generic arrays #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This pull request fixes issue with tokenising generics array. Example of code is below:
The reason why it was broken is variable pattern that now considers either generic declaration or primitive array (
[]
to be precise). The solution is combining those pattern into a chain rather than OR.Before this patch:

After:

Alternate Designs
Only one approach was considered - modifying
variables
pattern to handle such highlighting. Note that this is not very common in Java to use generics array like this, but is still worth fixing.Benefits
Fixes broken highlight. Works with my generics patch and does not break tests in master + in that patch.
Possible Drawbacks
Might break other untested corner cases.
Applicable Issues
None