This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Hide RegExp-specific grammars from selection menu #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of a `name` field is causing these two grammars to be shown in the grammar selection menu. Both are used internally to highlight the find-and-replace fields when using regexp-enabled seaching. References: atom/grammar-selector#34
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of
atom/grammar-selector#34, which patched the grammar selection menu to hide grammars without a definednamefield. Refer to the PR for rationale and prior discussion.This package contains two grammars which are (as far as I can tell) only used by
find-and-replaceto highlight input fields when the regex option is active. This should be enough to declare them "internal-use only".I left JSDoc alone because I'm not 100% sure whether hiding it is the right thing to do. Yes, the JSDoc grammar is used indirectly in the same way other "internal-use only" grammars are... however, its presence in the menu is far from conspicuous, as JSDoc is well-known to any JS dev worth their salt. I'll leave it to you to decide whether it should be hidden or not.
/cc @50Wliu
Related pull-requests:
atom/language-hyperlink#18atom/language-todo#65