New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide RegExp-specific grammars from selection menu #537

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@Alhadis
Contributor

Alhadis commented Sep 25, 2017

This PR is a follow-up of atom/grammar-selector#34, which patched the grammar selection menu to hide grammars without a defined name field. Refer to the PR for rationale and prior discussion.

This package contains two grammars which are (as far as I can tell) only used by find-and-replace to highlight input fields when the regex option is active. This should be enough to declare them "internal-use only".

I left JSDoc alone because I'm not 100% sure whether hiding it is the right thing to do. Yes, the JSDoc grammar is used indirectly in the same way other "internal-use only" grammars are... however, its presence in the menu is far from conspicuous, as JSDoc is well-known to any JS dev worth their salt. I'll leave it to you to decide whether it should be hidden or not.

/cc @50Wliu

Related pull-requests:

Hide RegExp-specific grammars from selection menu
The presence of a `name` field is causing these two grammars to be shown
in the grammar selection menu. Both are used internally to highlight the
find-and-replace fields when using regexp-enabled seaching.

References: atom/grammar-selector#34

@50Wliu 50Wliu merged commit 70138ec into atom:master Sep 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Alhadis Alhadis deleted the Cutlery-Drawer:hide-internal-grammars branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment