Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Flow files no longer have source.js scope, snippets broken #29

@IanVS

Description

@IanVS

Prerequisites

Description

Moved from atom/atom#18398.

When using the flow pragma in a file, all of my existing javascript snippets no longer work. I notice that the scope in these files no loner include source.js, which is what my snippets are expecting. Do I now need to duplicate all my snippets for both scopes, so I can work in files with and without flow? Do I need to recreate "built-in" snippets like log?

Steps to Reproduce

  1. Add // @flow to the top of a file
  2. Save the file, close, and reopen
  3. Notice that you can no longer type log and tab, and get console.log();

Expected behavior: [What you expect to happen]

Javascript snippets work in flow files.

Actual behavior: [What actually happens]

They don't.

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

Atom    : 1.33.0-beta1
Electron: 2.0.11
Chrome  : 61.0.3163.100
Node    : 8.9.3
apm  2.1.2
npm  6.2.0
node 8.9.3 x64
atom 1.33.0-beta1
python 2.7.10
git 2.19.1

Additional Information

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions