Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Strip username from host #103

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Strip username from host #103

merged 1 commit into from
Nov 2, 2017

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Nov 2, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Takes https://user@github.com/user/repo.git-style URLs and returns https://github.com/user/repo.git.
Also uses HTTPS where possible.

Alternate Designs

None.

Benefits

More accurate URL.

Possible Drawbacks

I don't see any? Everything should continue to work as long as you're logged into GitHub.

Applicable Issues

Fixes #72

@winstliu winstliu merged commit 4717fa6 into master Nov 2, 2017
@winstliu winstliu deleted the wl-strip-username branch November 2, 2017 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs are in the https://username@github.com/user/project format
1 participant