New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip username from host #103

Merged
merged 1 commit into from Nov 2, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 2, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Takes https://user@github.com/user/repo.git-style URLs and returns https://github.com/user/repo.git.
Also uses HTTPS where possible.

Alternate Designs

None.

Benefits

More accurate URL.

Possible Drawbacks

I don't see any? Everything should continue to work as long as you're logged into GitHub.

Applicable Issues

Fixes #72

@50Wliu 50Wliu merged commit 4717fa6 into master Nov 2, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-strip-username branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment