New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where false is never returned from snippetToExpandUnderCursor #253

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
4 participants
@leroix
Contributor

leroix commented Oct 31, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Oct 31, 2017

Contributor

Thanks for tracking this down!

Contributor

maxbrunsfeld commented Oct 31, 2017

Thanks for tracking this down!

@leroix leroix merged commit 7119d49 into master Oct 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@leroix leroix deleted the fix-bad-regex-bug branch Oct 31, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 31, 2017

Member

Sorry about this!

Member

50Wliu commented Oct 31, 2017

Sorry about this!

@leroix

This comment has been minimized.

Show comment
Hide comment
@leroix

leroix Oct 31, 2017

Contributor

@50Wliu no worries. Glad it was an easy fix.

Contributor

leroix commented Oct 31, 2017

@50Wliu no worries. Glad it was an easy fix.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Oct 31, 2017

Contributor

W00t!

No worries @50Wliu. I'm just glad you're keeping things flowing. Mistakes are inevitable.

Contributor

nathansobo commented Oct 31, 2017

W00t!

No worries @50Wliu. I'm just glad you're keeping things flowing. Mistakes are inevitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment