-
Notifications
You must be signed in to change notification settings - Fork 121
Added the possibility to exclude scopes #157
Conversation
Worked grate! 👍 thanks! |
The definition of the scope was too large for some languages and as a consequence some keywords were spell checked even though they were part of the language itself. With this change it is possible to have a greater control over which scopes are spell checked. E.g. In latex "\textit" will not be matched by the spell checker by specifying "support\.function\..*tex" as one of the excluded scopes.
Works for me! However, if you add/remove sth to/from "Excluded Grammars", it won't apply the new modification immediately... I need to change some other options too or reopen Atom to apply it. |
Is there any eta if this is going to get merged any time soon? If not, what is blocking this? Seems like a very good addition. |
Is there a particular reason we are waiting on this to be merged? Would really like to see this fix implemented. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This doesn't seem to be in atom yet. Is there a way to integrate this to an installed version of atom ? (on Ubuntu) |
This comment has been minimized.
This comment has been minimized.
I'm also wondering if this is going to be merged eventually, or if we should start using linter-spell-latexsimple instead? |
This should really be merged - I'm using pandoc markdown with math mode and there it would be useful as well to disable spell checking inside math expressions. |
@damieng @smashwilson Is there a blocker preventing this from being merged? It's been waiting for over a year now with no update on what's stopped it. I'm not even mad I just really want to be able to spellcheck LaTeX files without copying across to another texteditor that supports it. |
I'm not that familiar with this package but seeing regexe's created and tested in a loop is one reason it's not just a hit-merge. We need to understand how that affects performance. How often during regular typing is that code path hit? |
From the Atom Flight Manual:
It makes me wonder if Atom provides a more efficient and featured way to filter scopes (perhaps via Sizzle). For example, to spellcheck markdown except code and URIs, I could add something like this to included scopes: text.md:not(source.embedded):not(uri) EDIT: I cannot seem to find it, but I am 99% sure I've seen this convention used elsewhere in the Atom codebase. |
Hi @dn0sar, everyone. I'm really sorry that it took us this long to implement this feature. I have implemented similar functionality but based on (limited) scope selectors instead of regexes in #234. This feature will ship in Atom 1.25. You'll be able to put this type of thing in 'spell-check.excludedScopes': [
'.support.function.tex'
] |
@maxbrunsfeld For LaTeX blacklisted scopes, assuming it gets core support, there is already a list compiled in These scopes are compatible with |
@maxbrunsfeld I am running into some problems with spell-check and following configuration: I inserted the |
I am facing the same problem as @vthuongt mentioned... |
For posterity, I needed to add a number of exclusions to get good behavior (though still not perfect)
|
The definition of the scope was too large for some languages and
as a consequence some keywords were spell checked even though
they were part of the language itself.
With this change it is possible to have a greater control over
which scopes are spell checked.
E.g. In latex "\textit" will not be matched by the spell checker
by specifying "support.function..*tex" as one of the
excluded scopes.
Fixes #2, #19, #117, #118 and #126