This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Optimize scan when using single-line regexps #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time when searching a buffer, the search regex can only match within a single line. This is the case whenever the regex doesn't contain an explicit line ending character (
\n
or\r
) or a negated character class (e.g.[^\w]
). In this situation, we can avoid two inefficient aspects of the current search algorithm:We can avoid joining the buffer's text into a single string to pass to
Regex.exec
and then translating the resulting match positions back into 2-dimensional buffer ranges with theBufferOffsetIndex
. Instead we can search each line individually, keeping track of the row as we go, so that we can provide the ranges with no cost.When searching backwards, there's no need for the back-off algorithm that we currently use to avoid searching from the beginning of the text. We can simply iterate through the lines in reverse.
/cc @nathansobo