This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Handle out-of-range folds when populating the spatial index #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initially populating the spatial index, the row range isn't expanded to account for overlapping fold row ranges because the index isn't populated yet. When `updateSpatialIndex` is called with an `oldEndBufferRow` exceeding the indexed buffer row count, we need to perform additional queries to the `foldsMarkerLayer` if folds exceed the requested buffer row range to ensure folds with intersecting row ranges are correctly inserted into the index. This commit also adds a randomized test focusing exclusively on the issue of a pre-populated `foldsMarkerLayer`.
|
👏 Nice! |
nathansobo
pushed a commit
that referenced
this pull request
Feb 17, 2017
Handle out-of-range folds when populating the spatial index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initially populating the spatial index, the row range isn't expanded to account for overlapping fold row ranges because the index isn't populated yet.
When
updateSpatialIndexis called with anoldEndBufferRowexceeding the indexed buffer row count, we need to perform additional queries to thefoldsMarkerLayerif folds exceed the requested buffer row range to ensure folds with intersecting row ranges are correctly inserted into the index.This PR also adds a randomized test focusing exclusively on the issue of a pre-populated
foldsMarkerLayer./cc @maxbrunsfeld