-
Notifications
You must be signed in to change notification settings - Fork 68
Description
The Commits list at AtomicData.dev is apparently empty, which is not correct. Exporting the data shows that there are commits there.
I think it's not properly indexing the Commits. At the end of apply
, we can see that store.add_resource()
is called for both. In the case of the Commit, however, this is a problem as it wasn't indexed before.
One approach, is to index on add_resource
. The advantage of this, is that it becomes safer to use this function. However, it is a bit more expensive, as now all properties will always be re-indexed, even if they did not change.
we could also add a add_resource_indexed
function, and let the user decide which one it needs. Or maybe let add_resource
by default construct add to index and add a add_resource_unindexed
function for very rare usecases (e.g. in the apply
function for commits).
- Add a test for Commit indexing
- Make sure commits are indexed