-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many mini fixes #18
Many mini fixes #18
Conversation
…gical just returns input
and update documentation
…n empty dataset for it. Meaning empty derivation and codelist is fine
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 79.42% 84.21% +4.78%
==========================================
Files 6 6
Lines 802 836 +34
==========================================
+ Hits 637 704 +67
+ Misses 165 132 -33
Continue to review full report at Codecov.
|
@statasaurus I'd like to try to fix the failures for R 3.5 and 3.6. Have you looked into those at all? |
@kodesiba since you and Christina discussed a lot of these changes, could you check out these updates? @statasaurus can you add a NEWS.md file so we can throw the changelog up on the pkgdown too? |
I didn't see an issue for this? Is it somewhere to look at? |
@statasaurus see here. Any time we merge with main we should update this and the version. |
…n older version but not on current versions
@kodesiba can you review this now? It is passing all the checks it should and I have added a news page |
@statasaurus @mstackhouse everything here looks good to me. Super excited with these changes! |
This will fix almost all the current issues. None of which were huge so I didn't feel like they justified their own branch.
yn_to_tf()
should function if input variable is already boolean #10 yn function checks for logicals and returns themkey_seq
is not supported inspec_type_to_ds_vars()
unless it is in an external sheet #11 updated function description to make this clearerformat
element ofcols
vector inspec_type_to_var_spec()
only accepts 'Format' and not 'format' as the column name #12 updated regex so to [F|f]ormat so it can accept lower caseOnce this is merged in do you want to submit to CRAN? it will probably fail, but it will give us another bolus of issues to tackle