Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many mini fixes #18

Merged
merged 18 commits into from
Jan 4, 2022
Merged

Many mini fixes #18

merged 18 commits into from
Jan 4, 2022

Conversation

statasaurus
Copy link
Collaborator

This will fix almost all the current issues. None of which were huge so I didn't feel like they justified their own branch.

Once this is merged in do you want to submit to CRAN? it will probably fail, but it will give us another bolus of issues to tackle

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #18 (4f239dc) into main (05608da) will increase coverage by 4.78%.
The diff coverage is 68.88%.

❗ Current head 4f239dc differs from pull request most recent head fb83d5b. Consider uploading reports for the commit fb83d5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   79.42%   84.21%   +4.78%     
==========================================
  Files           6        6              
  Lines         802      836      +34     
==========================================
+ Hits          637      704      +67     
+ Misses        165      132      -33     
Impacted Files Coverage Δ
R/spec_builder.R 68.85% <12.50%> (-2.10%) ⬇️
R/metacore.R 90.32% <100.00%> (+4.04%) ⬆️
R/validators.R 91.78% <100.00%> (+27.89%) ⬆️
R/xml_builders.R 94.70% <100.00%> (+0.03%) ⬆️
R/xml_helpers.R 92.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05608da...fb83d5b. Read the comment docs.

@mstackhouse
Copy link
Contributor

@statasaurus I'd like to try to fix the failures for R 3.5 and 3.6. Have you looked into those at all?

@mstackhouse
Copy link
Contributor

@kodesiba since you and Christina discussed a lot of these changes, could you check out these updates?

@statasaurus can you add a NEWS.md file so we can throw the changelog up on the pkgdown too?

@statasaurus
Copy link
Collaborator Author

I didn't see an issue for this? Is it somewhere to look at?

@mstackhouse
Copy link
Contributor

@statasaurus see here. Any time we merge with main we should update this and the version.

@statasaurus
Copy link
Collaborator Author

@kodesiba can you review this now? It is passing all the checks it should and I have added a news page

@kodesiba
Copy link

kodesiba commented Jan 4, 2022

@statasaurus @mstackhouse everything here looks good to me. Super excited with these changes!

@mstackhouse mstackhouse merged commit ac85a78 into main Jan 4, 2022
@statasaurus statasaurus deleted the many_mini_fixes branch January 7, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants