Update Metro M4 BSP and examples for v2/tier1 #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we merge this even though the SAMD51 still seems to be buggy? |
10 tasks
TDHolmes
approved these changes
Sep 19, 2021
| &mut peripherals.MCLK, | ||
| (rx, tx), | ||
| ); | ||
| let mut a0 = pins.a0.into_alternate::<B>(); |
There was a problem hiding this comment.
Could use the aliases feature for this one:
let mut a0: bsp::Analog0 = pins.a0.into();and lib.rs would have something like:
PA02 {
/// Analog pin 0. Can act as a true analog output
/// as it has a DAC (which is not currently supported
/// by this hal) as well as input.
name: a0,
aliases: {
AlternateB: Analog0
}| .configure_gclk_divider_and_source(GCLK2, 12, DPLL0, false) | ||
| .unwrap(); | ||
| pins.d13.into_function_m(&mut pins.port); | ||
| let _ = pins.d7.into_alternate::<M>(); |
There was a problem hiding this comment.
similar into() comment here
There was a problem hiding this comment.
This is an example-specific pin, not a board-specific one, so it should be in the example, not the bsp.
|
|
||
| let d12 = pins.d12.into_function_e(&mut pins.port); | ||
| let d12 = pins.d12.into_alternate::<E>(); |
There was a problem hiding this comment.
similar into() comment here
| } | ||
|
|
||
| pub type UartPads = uart::Pads<Sercom3, IoSet1, UartRx, UartTx>; |
There was a problem hiding this comment.
since its public, should we doc?
sajattack
force-pushed
the
metro_m4_update
branch
from
efae333 to
fa38a69
Compare
|
@TDHolmes I'm not totally sold on the need for all the different aliases, so I just added the doc comment you recommended. Maybe we can have a discussion about it on matrix at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.