Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undocumented IOSet #506

Merged
merged 4 commits into from
Oct 10, 2021
Merged

Conversation

TDHolmes
Copy link
Contributor

@TDHolmes TDHolmes commented Oct 5, 2021

Summary

ATSAMD5x/ATSAME5x has an undocumented IOSet that some of our boards use. Stealing this implementation from @bradleyharden to get it in before the rest of his changes land to un-block #487

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

@bradleyharden
Copy link
Contributor

bradleyharden commented Oct 5, 2021

@TDHolmes, you only need to add the separate, UndocIoSet type definition to pad.rs. The rest of the changes come from a refactor to reduce the usage of #[cfg(feature = "min-samd51g")]. You can probably leave that refactoring in #467.

@TDHolmes
Copy link
Contributor Author

TDHolmes commented Oct 9, 2021

Tested this on the feather_m4 branch and it works as expected @bradleyharden . I'll wait for this to merge before touching that branch though

@bradleyharden bradleyharden merged commit 17afec4 into atsamd-rs:master Oct 10, 2021
kaizensparc pushed a commit to kaizensparc/atsamd that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants