Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin host startup fixes #3980

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Plugin host startup fixes #3980

merged 3 commits into from
Nov 30, 2022

Conversation

vsverchinsky
Copy link
Contributor

@vsverchinsky vsverchinsky commented Nov 25, 2022 •
edited
Loading

Resolves: #3256
Resolves: #3802

Disables breakpad handler in plugin host process. Presumably that can fix #3802 on MacOS/Linux.
Hides plugin host process icon from dock on MacOS and prevents native crash report dialog to appear #3256.

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

This was linked to issues Nov 25, 2022
'Audacity quit unexpectedly' when discovering a plugin that requires activation #3256
Closed
Add a skip option + timeout to plugin validation #3802
Closed
@Paul-Licameli
Copy link
Collaborator

The changes in AudacityApp.cpp remind me that ideally the plugin host should be a different, smaller executable with its own main() that doesn't load so much other unnecessary code. But that would be a future improvement.

@vsverchinsky
IPC socket behaviour fix on Linux/MacOS
99415b0 
Crash report dialog created with `fork` keeps IPC socket open. That blocked a server process on `select` until user closes a dialog
@vsverchinsky
Disable Breakpad handler in host process
4628538
@vsverchinsky
Hide plugin host icon in the dock area on MacOS
e42478c
@vsverchinsky vsverchinsky merged commit 0c42d00 into audacity:release-3.2.2 Nov 30, 2022
@vsverchinsky vsverchinsky deleted the plugin-host-startup-fixes branch November 30, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crsib crsib crsib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vsverchinsky @Paul-Licameli @crsib