Change the names of launch files to be _launch.py #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the current best practice, which we updated in Iron. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
6 tasks
tylerjw
approved these changes
May 3, 2023
|
Looks good, thank you for updating this. |
Yadunund
approved these changes
May 4, 2023
6 tasks
6 tasks
Yadunund
pushed a commit
that referenced
this pull request
Jun 20, 2023
This matches the current best practice, which we updated in Iron. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Yadunund
added a commit
that referenced
this pull request
Jul 13, 2023
* move humble requirements to root Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update tier 3 os labels and remove source from jammy Signed-off-by: Yadunund <yadunund@openrobotics.org> * Tmp fix for redirected links in sitemap that cause duplicate requirements Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added an expectation for param delete Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix prompt for service find Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update bag info with mcap Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added details for component cli tests Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add checks for ros1_bridge Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added tests for service introspection Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add check for asunc_param_client Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix duplicate py checks Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add DISTRO_LABEL constant Signed-off-by: Yadunund <yadunund@openrobotics.org> * Use DISTRO const to retrieve docs Signed-off-by: Yadunund <yadunund@openrobotics.org> * Change the names of launch files to be _launch.py (#347) This matches the current best practice, which we updated in Iron. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Update the service executables demon_nodes_py test to use async. (#348) There is no '_sync' version, so this must have been a typo for the '_async' version, which does exist. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Add the holonomic parameter to turtlesim tests. (#350) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * remove extra slash to output correct command (#353) Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix input (#352) Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add linux label to realtime tests (#351) Signed-off-by: Yadunund <yadunund@openrobotics.org> * tag linux (#357) Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix up the multicast test to have a try and expect section. (#355) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Add in a missing component container name in a test. (#354) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Specify frame ids for static transform publisher (#358) Signed-off-by: Yadunund <yadunund@openrobotics.org> * Replace executables with link to demos readme (#365) * Replace executables with link to demos readme Signed-off-by: Yadunund <yadunund@openrobotics.org> * address feedback Signed-off-by: Yadunund <yadunund@openrobotics.org> --------- Signed-off-by: Yadunund <yadunund@openrobotics.org> * Change references to humble -> iron (#370) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Modifies the console input to test out rqt (#374) Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Adds the label to only test in linux gazebo_ros_pkgs (#392) Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Removes test cases for Windows (#394) Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Adds a clearer description for the idl message generation (#390) * Adds a clearer description of the test Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Replace executables with link to demos readme (#395) * Replace executables with link to demos readme Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Adds the full path to the launch testing stdin (#393) * Adds the full path to the launch testing stdin * Adds instructions to clone the repository Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Filter redirects in docs.ros.org sitemap (#405) * Ignore redirects Signed-off-by: Yadunund <yadunund@openrobotics.org> * Moved iron requirements to ros2_test_cases Signed-off-by: Yadunund <yadunund@openrobotics.org> * Restore garden backup Signed-off-by: Yadunund <yadunund@openrobotics.org> * Parse YAML_DISTRO_LABEL Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update readme and ci Signed-off-by: Yadunund <yadunund@openrobotics.org> * Format Signed-off-by: Yadunund <yadunund@openrobotics.org> * Make YATM_DISTRO_LABEL a required param Signed-off-by: Yadunund <yadunund@openrobotics.org> --------- Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Voldivh <eloyabmfcv@gmail.com> Co-authored-by: Yadunund <yadunund@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the current best practice, which we updated in Iron.
@Yadunund FYI. I don't think we should regenerate the tests or anything for this, but at least this will be correct for next year.