Skip to content

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Jul 3, 2025

This PR fixes a failing test which checks if it's deleted by checking if expiry time is unix epoch 0. We use max-age=0 since #2200 so this should be checked instead.
This was not caught in #2200 bc the branch was not updated with main (github showed that there were no changed files b/w pr and main but testing strategy was changed)

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner July 3, 2025 15:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (268688d) to head (fbe91b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
+ Coverage   84.20%   84.23%   +0.03%     
==========================================
  Files          22       22              
  Lines        2203     2208       +5     
  Branches      396      397       +1     
==========================================
+ Hits         1855     1860       +5     
  Misses        342      342              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tusharpandey13 tusharpandey13 merged commit 3d0232e into main Jul 3, 2025
12 checks passed
@tusharpandey13 tusharpandey13 deleted the bugfix/cookie-maxage-test-fix branch July 3, 2025 15:28
@tusharpandey13 tusharpandey13 mentioned this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants