Skip to content

Remove test files from module build #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Remove test files from module build #79

wants to merge 11 commits into from

Conversation

dosullivan557
Copy link
Contributor

@dosullivan557 dosullivan557 commented Jan 29, 2021 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@dosullivan557 dosullivan557 requested a review from a team as a code owner January 29, 2021 19:50
@dosullivan557
Copy link
Contributor Author

Hi @ja30278 @pol @chrisscott @jstrutz - could you review this pr please.

I install your module in an application, it copies over .pem and .key files that are in your tests. This means that when we put our application through security scans, it fails because it finds these files and classifies them as sensitive data. What I'm asking is whether you can not include these in the bundled version of the application.

To resolve it, you can have a section in the package.json that doesn't pull the test files over to the build of the module when it is pulled in.

@gkwang
Copy link
Contributor

gkwang commented Feb 1, 2021

Hi @dosullivan557, changes look good. Do you mind signing the commit since we have that enabled in order to merge the changes.
I'll get it merged as soon as that's done.

Thanks for the contribution!

@dosullivan557
Copy link
Contributor Author

Hey @gkwang - I pushed a signed commit up - lemme know if there's anything else

@dosullivan557
Copy link
Contributor Author

Hey @gkwang - any update on this?

gkwang
gkwang previously approved these changes Feb 8, 2021
View reviewed changes
@gkwang
Copy link
Contributor

gkwang commented Feb 8, 2021 •
edited
Loading

@dosullivan557, Sorry I missed your last message. All commits needs to be signed, so you'll need to squash the commits, sign it and do a force push.

dosullivan557 and others added 6 commits February 8, 2021 19:26
@dosullivan557
Squashed commit of the following:
4433665 
commit 3bf0d4d
Author: Daniel OSullivan <dosullivan557@gmail.com>
Date:   Tue Feb 2 09:37:59 2021 +0000

    Signed commit

commit cd7a776
Author: Daniel O'Sullivan <daniel.o'sullivan@lloydsbanking.com>
Date:   Mon Feb 1 23:08:24 2021 +0000

    Sorted out whitespace

commit e992195
Author: Daniel O'Sullivan <daniel.o'sullivan@lloydsbanking.com>
Date:   Fri Jan 29 19:50:02 2021 +0000

    Formatting

commit 960eda2
Author: Daniel O'Sullivan <daniel.o'sullivan@lloydsbanking.com>
Date:   Fri Jan 29 19:49:03 2021 +0000

    Update package.json

commit f412aac
Merge: 52183cb 9b6df94
Author: Eva Sarafianou <eva.sarafianou@gmail.com>
Date:   Wed Sep 9 09:11:19 2020 +0200

    Merge pull request #76 from auth0/update_forge

    Update node-forge to the latest version

commit 9b6df94
Author: Eva Sarafianou <eva.sarafianou@auth0.com>
Date:   Tue Sep 8 19:59:05 2020 +0200

    Bumps a new patch version

commit cd9c41d
Author: Eva Sarafianou <eva.sarafianou@auth0.com>
Date:   Tue Sep 8 19:50:32 2020 +0200

    Update node-forge to the latest version

    Updating it addresses a secuity issue:
    https://snyk.io/vuln/SNYK-JS-NODEFORGE-598677

commit 52183cb
Merge: 1f013c5 62abb0f
Author: matauth0 <60881036+matauth0@users.noreply.github.com>
Date:   Wed Jul 8 11:09:46 2020 +0200

    Merge pull request #73 from auth0/esarafianou-codeql-scan

    Create codeql-analysis.yml to trigger scans

commit 62abb0f
Author: Eva Sarafianou <eva.sarafianou@gmail.com>
Date:   Wed Jul 8 09:55:36 2020 +0200

    Create codeql-analysis.yml to trigger scans

commit 1f013c5
Author: George <george.wang@auth0.com>
Date:   Thu May 7 15:22:26 2020 -0700

    release 1.2.0 (#72)

commit b5a912b
Author: Chris West <solo-github@goeswhere.com>
Date:   Wed May 6 22:44:24 2020 +0100

    feat: sinon is a dev dependency (#71)

commit 30edc80
Author: George <george.wang@auth0.com>
Date:   Tue Mar 31 14:55:16 2020 -0700

    fix(utils): fix accidental duplicate export. (#70)

    Fix for styling; no behavior impact.

commit 77efd10
Author: George <george.wang@auth0.com>
Date:   Wed Mar 25 12:33:27 2020 -0700

    chore: release 1.1.0 (#69)

    Also updated README to fix formatting.
    Added a release section.

commit 25d22fd
Author: George <george.wang@auth0.com>
Date:   Wed Mar 25 11:38:51 2020 -0700

    feat: Add warning when insecure algorithm is used. (#68)

    The warning is piped to stderr using console.warn().
    Added option to turn it off; defaults to true.

commit f5651cc
Author: George <george.wang@auth0.com>
Date:   Tue Mar 24 10:02:24 2020 -0700

    feat: Add support for AES-GCM family (#67)

    Also bumped mocha version for dependency fix.

Signed-off-by: Daniel OSullivan <dosullivan557@gmail.com>
@dosullivan557
Merge branch 'master' of https://github.com/dosullivan557/node-xml-en…
09f71b7 
…cryption
@gkwang @dosullivan557
Fix a missing check in encryption for encrypt call (#64)
dab88b9 
* Fix typo in readme and tests

for for insecure algorithm options

* Fix a missing check in encryption for encrypt call

Fix a callback to match callback error signature
Add additional tests
Fix README and test typos
@gkwang @dosullivan557
v1.0.0 release (#65)
4dcc4a6
@dosullivan557
Squashed commit of the following:
7017184 
commit 3bf0d4d
Author: Daniel OSullivan <dosullivan557@gmail.com>
Date:   Tue Feb 2 09:37:59 2021 +0000

    Signed commit

commit cd7a776
Author: Daniel O'Sullivan <daniel.o'sullivan@lloydsbanking.com>
Date:   Mon Feb 1 23:08:24 2021 +0000

    Sorted out whitespace

commit e992195
Author: Daniel O'Sullivan <daniel.o'sullivan@lloydsbanking.com>
Date:   Fri Jan 29 19:50:02 2021 +0000

    Formatting

commit 960eda2
Author: Daniel O'Sullivan <daniel.o'sullivan@lloydsbanking.com>
Date:   Fri Jan 29 19:49:03 2021 +0000

    Update package.json

commit f412aac
Merge: 52183cb 9b6df94
Author: Eva Sarafianou <eva.sarafianou@gmail.com>
Date:   Wed Sep 9 09:11:19 2020 +0200

    Merge pull request #76 from auth0/update_forge

    Update node-forge to the latest version

commit 9b6df94
Author: Eva Sarafianou <eva.sarafianou@auth0.com>
Date:   Tue Sep 8 19:59:05 2020 +0200

    Bumps a new patch version

commit cd9c41d
Author: Eva Sarafianou <eva.sarafianou@auth0.com>
Date:   Tue Sep 8 19:50:32 2020 +0200

    Update node-forge to the latest version

    Updating it addresses a secuity issue:
    https://snyk.io/vuln/SNYK-JS-NODEFORGE-598677

commit 52183cb
Merge: 1f013c5 62abb0f
Author: matauth0 <60881036+matauth0@users.noreply.github.com>
Date:   Wed Jul 8 11:09:46 2020 +0200

    Merge pull request #73 from auth0/esarafianou-codeql-scan

    Create codeql-analysis.yml to trigger scans

commit 62abb0f
Author: Eva Sarafianou <eva.sarafianou@gmail.com>
Date:   Wed Jul 8 09:55:36 2020 +0200

    Create codeql-analysis.yml to trigger scans

commit 1f013c5
Author: George <george.wang@auth0.com>
Date:   Thu May 7 15:22:26 2020 -0700

    release 1.2.0 (#72)

commit b5a912b
Author: Chris West <solo-github@goeswhere.com>
Date:   Wed May 6 22:44:24 2020 +0100

    feat: sinon is a dev dependency (#71)

commit 30edc80
Author: George <george.wang@auth0.com>
Date:   Tue Mar 31 14:55:16 2020 -0700

    fix(utils): fix accidental duplicate export. (#70)

    Fix for styling; no behavior impact.

commit 77efd10
Author: George <george.wang@auth0.com>
Date:   Wed Mar 25 12:33:27 2020 -0700

    chore: release 1.1.0 (#69)

    Also updated README to fix formatting.
    Added a release section.

commit 25d22fd
Author: George <george.wang@auth0.com>
Date:   Wed Mar 25 11:38:51 2020 -0700

    feat: Add warning when insecure algorithm is used. (#68)

    The warning is piped to stderr using console.warn().
    Added option to turn it off; defaults to true.

commit f5651cc
Author: George <george.wang@auth0.com>
Date:   Tue Mar 24 10:02:24 2020 -0700

    feat: Add support for AES-GCM family (#67)

    Also bumped mocha version for dependency fix.

Signed-off-by: Daniel OSullivan <dosullivan557@gmail.com>
@dosullivan557
squash
d5f253e
@dosullivan557
Copy link
Contributor Author

Hi @gkwang - I was getting into a bit of a mess, so decided to start again with a fresh PR - see the please see PR #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkwang gkwang gkwang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dosullivan557 @gkwang